Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy rand_tangent(::BigFloat) from ChainRulesTestUtils #155

Merged
merged 5 commits into from
May 4, 2021
Merged

Conversation

mzgubic
Copy link
Member

@mzgubic mzgubic commented Apr 8, 2021

@mzgubic mzgubic changed the title copy BigFloat rand_tangent from ChainRulesTestUtils WIP copy BigFloat rand_tangent from ChainRulesTestUtils Apr 8, 2021
This reverts commit 09f6da2.
@mzgubic mzgubic changed the title WIP copy BigFloat rand_tangent from ChainRulesTestUtils copy BigFloat rand_tangent from ChainRulesTestUtils Apr 8, 2021
@mzgubic mzgubic changed the title copy BigFloat rand_tangent from ChainRulesTestUtils copy rand_tangent(::BigFloat) from ChainRulesTestUtils Apr 8, 2021
@mzgubic
Copy link
Member Author

mzgubic commented May 4, 2021

@oxinabox this is the first step towards a single rand_tangent function

src/rand_tangent.jl Outdated Show resolved Hide resolved
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that moving things into FiniteDifferences is the right way, but it certainly is less suffering than having it in both.

Co-authored-by: Lyndon White <oxinabox@ucc.asn.au>
@mzgubic mzgubic merged commit f46293a into master May 4, 2021
mzgubic added a commit that referenced this pull request May 6, 2021
#155 did not show conflict for some reason (it bumped to 0.12.3 which in the meantime became what master was)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants