remove CachedMethodTable
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apologize for the confusion! In <JuliaLang/julia#44240>, we figured out that `CachedMethodTable` doesn't give us any performance benefit (both in time and space), and so we removed that from Julia Base. This commit updates the (newly updated) GPUCompiler's overloads accordingly.
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 85.67% 85.67%
=======================================
Files 22 22
Lines 2073 2073
=======================================
Hits 1776 1776
Misses 297 297
Continue to review full report at Codecov.
|
|
No problem, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologize for the confusion!
In JuliaLang/julia#44240, we figured out that
CachedMethodTabledoesn't give us any performance benefit (both intime and space), and so we removed that from Julia Base.
This commit updates the (newly updated) GPUCompiler's overloads accordingly.