Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in intro example #379

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Fix typo in intro example #379

merged 2 commits into from
Sep 25, 2023

Conversation

willtebbutt
Copy link
Member

Summary

Fixes noise-related problem raised in #378

Proposed changes

Add the correct noise variance wherever posterior log marginal likelihoods are asked for.

What alternatives have you considered?

None

Breaking changes

N/A

@willtebbutt willtebbutt mentioned this pull request Sep 19, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

st--
st-- approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@st-- st-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm... I'm just thinking if it'd be more helpful to have an explicit variable noise_var = 0.1 and then use that in the arguments ?

@willtebbutt
Copy link
Member Author

lgtm... I'm just thinking if it'd be more helpful to have an explicit variable noise_var = 0.1 and then use that in the arguments ?

This is a good point. I'll modify this, then merge when CI passes.

@willtebbutt willtebbutt merged commit 083c772 into master Sep 25, 2023
12 checks passed
@willtebbutt willtebbutt deleted the wct/update-example branch September 25, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st-- st-- st-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willtebbutt @st--