Enable periodic kernel in example #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that JuliaGaussianProcesses/KernelFunctions.jl#528 has been merged, we can try re-enabling the `PeriodicKernel`
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 12 12
Lines 394 394
=======================================
Hits 382 382
Misses 12 12 ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
willtebbutt
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
This looks to me to be working from the docs that have been built during CI. @simsurace do you agree?
|
Yeah everything works, I tested locally as well. There is also a unit test for AD through the periodic kernel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that JuliaGaussianProcesses/KernelFunctions.jl#531 has been merged, we can try re-enabling the
PeriodicKernel.