Bringing the .github/workflows/postbench.yml to master
#350
Conversation
(WIP) TODO: store results and PR label triggering
Merge all new advancements on the `benchx` branch in order to do a follow up consecutive PR to test github actions
* Trivial change, test PR * Add PR write permission * Test full permissions * Granular permissions * try write-all * try label event * labeled in pull_request * Store results as artifact and trigger a consecutive workflow_run * Workflow chain almost complete (WIP) * correct .benchmarkci path * Add benchx support branch * Just try pull_request_target instead * Remove target * Get rid of s to get the chain going --------- Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com>
|
Thanks for the PR, I'll review soon. In accordance with the ColPrac guidelines, please don't push directly and instead open a PR + wait for review if you want to change the master branch. |
|
ok, btw is it normal that the CI fails so hard and that the nighly is still in progress after 3 hours ? |
|
Nightly is unpredictable, but the rest is not normal no |
|
It's the formatting |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #350 +/- ##
=======================================
Coverage 97.28% 97.29%
=======================================
Files 115 117 +2
Lines 6789 6814 +25
=======================================
+ Hits 6605 6630 +25
Misses 184 184 ☔ View full report in Codecov by Sentry. |
|
@gdalle thanks for the review. Please mark all discussions you are satisfied with as "resolved". When all are resolved I will make the changes. |
|
Following ColPrac @filchristou you can merge your own PR after review since you have the rights |
as discussed in the community call, the trigger workflow file needs to be in the default, i.e. master, branch.
I guess I shouldn't push directly to master, so I made this PR, but maybe for future iterations it makes more sense if I can push directly. That might create some commits, but as already discussed they are not user critical since changes are only made to the CI.