Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document default direction (:both) in laplacian_matrix and others #41

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Apr 6, 2023

Partially solves #24 without breaking backwards compatibility

@gdalle gdalle changed the title Make laplacian_matrix coherent with :both convention Document default direction (:both) in laplacian_matrix and others Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #41 (543409d) into master (4b2d7ff) will not change coverage.
The diff coverage is n/a.

❗ Current head 543409d differs from pull request most recent head c164df2. Consider uploading reports for the commit c164df2 to get more accurate results

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files           9        9           
  Lines         445      445           
=======================================
  Hits          422      422           
  Misses         23       23           
Impacted Files Coverage Δ
src/overrides.jl 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gdalle gdalle merged commit d995ffd into master Apr 6, 2023
@gdalle gdalle deleted the fix_laplacian branch April 6, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant