Skip to content

Commit

Permalink
deprecate time datatype (#467)
Browse files Browse the repository at this point in the history
time datatype is deprecated and broken according to https://docs.h5py.org/en/stable/special.html#storing-other-types-as-opaque-data

Co-authored-by: Dani Pinyol <dani@avatarcognition.com>
  • Loading branch information
dpinol and Dani Pinyol committed Mar 30, 2023
1 parent eb6b2ae commit 30dd578
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/datatypes.jl
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ macro read_datatype(io, datatype_class, datatype, then)
elseif $datatype_class << 4 == DT_BITFIELD << 4
$(replace_expr(then, datatype, :(jlread($io, BitFieldDatatype))))
elseif $datatype_class << 4 == DT_TIME << 4
$(replace_expr(then, datatype, :(jlread($io, TimeDatatype))))
throw(UnsupportedFeatureException("Time datatype (rarely used) not supported"))
elseif $datatype_class << 4 == DT_ARRAY << 4
$(replace_expr(then, datatype, :(jlread($io, ArrayDatatype))))
elseif $datatype_class << 4 == DT_ENUMERATED << 4
Expand Down

0 comments on commit 30dd578

Please sign in to comment.