add connect timeout; reinstate speed limit #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds a connection timeout of 30 seconds, closing #125 - It re-instates the lower speed limit that was briefly added in #85 and was accidentally reverted in the following pull request (#86) In combination, this should prevent downloads from hanging, whether because the server is unavailable and so the connection is never established, or because the server never sends any data after the connection is established. This does not put an absolute timeout on downloads since a very large download can take arbitrarily long while still making progress.
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 92.98% 93.03% +0.04%
==========================================
Files 5 5
Lines 485 488 +3
==========================================
+ Hits 451 454 +3
Misses 34 34
Continue to review full report at Codecov.
|
StefanKarpinski
added a commit
that referenced
this pull request
Jun 1, 2021
- This adds a connection timeout of 30 seconds, closing #125 - It re-instates the lower speed limit that was briefly added in #85 and was accidentally reverted in the following pull request (#86) In combination, this should prevent downloads from hanging, whether because the server is unavailable and so the connection is never established, or because the server never sends any data after the connection is established. This does not put an absolute timeout on downloads since a very large download can take arbitrarily long while still making progress. (cherry picked from commit 84e948c)
StefanKarpinski
added a commit
that referenced
this pull request
Jun 1, 2021
- This adds a connection timeout of 30 seconds, closing #125 - It re-instates the lower speed limit that was briefly added in #85 and was accidentally reverted in the following pull request (#86) In combination, this should prevent downloads from hanging, whether because the server is unavailable and so the connection is never established, or because the server never sends any data after the connection is established. This does not put an absolute timeout on downloads since a very large download can take arbitrarily long while still making progress. (cherry picked from commit 84e948c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In combination, this should prevent downloads from hanging, whether because the server is unavailable and so the connection is never established, or because the server never sends any data after the connection is established. This does not put an absolute timeout on downloads since a very large download can take arbitrarily long while still making progress.