Normalize index to CartesianIndex in _modify! (#33187)

JuliaLang · Sep 8, 2019 · 6a20ad7 · 6a20ad7 · nanosoldier · Sep 9, 2019
1 parent 3424d2c
commit 6a20ad7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/stdlib/LinearAlgebra/src/generic.jl b/stdlib/LinearAlgebra/src/generic.jl
@@ -61,12 +61,15 @@ julia> C
 """
 @inline @propagate_inbounds function _modify!(p::MulAddMul{ais1, bis0},
                                               x, C, idx′) where {ais1, bis0}
-    # Workaround for performance penalty of splatting a number (#29114):
-    idx = idx′ isa Integer ? (idx′,) : idx′
+    # `idx′` may be an integer, a tuple of integer, or a `CartesianIndex`.
+    #  Let `CartesianIndex` constructor normalize them so that it can be
+    # used uniformly.  It also acts as a workaround for performance penalty
+    # of splatting a number (#29114):
+    idx = CartesianIndex(idx′)
     if bis0
-        C[idx...] = p(x)
+        C[idx] = p(x)
     else
-        C[idx...] = p(x, C[idx...])
+        C[idx] = p(x, C[idx])
     end
     return
 end

diff --git a/stdlib/LinearAlgebra/test/matmul.jl b/stdlib/LinearAlgebra/test/matmul.jl
@@ -575,4 +575,10 @@ end
     end
 end
 
+@testset "CartesianIndex handling in _modify!" begin
+    C = rand(10, 10)
+    A = rand(10, 10)
+    @test mul!(view(C, 1:10, 1:10), A, 0.5) == A * 0.5
+end
+
 end # module TestMatmul