Skip to content

Commit

Permalink
Work around invalid register errors with 64-bit Windows (#28449)
Browse files Browse the repository at this point in the history
Adding `-fno-asynchronous-unwind-tables` to the C compiler flags passed
to OpenBLAS works around errors claiming an invalid register for
`.seh_savexmm`. We've been running into this on the 64-bit Windows
buildbots.

See discussion in OpenMathLib/OpenBLAS#1708.
  • Loading branch information
ararslan authored and KristofferC committed Feb 11, 2019
1 parent 0b9da90 commit 6f6d5de
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions deps/blas.mk
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@ OPENBLAS_FFLAGS += -mincoming-stack-boundary=2
endif
endif

# Work around invalid register errors on 64-bit Windows
# See discussion in https://github.com/xianyi/OpenBLAS/issues/1708
# TODO: Remove this once we use a version of OpenBLAS where this is set automatically
ifeq ($(OS),WINNT)
ifeq ($(ARCH),x86_64)
OPENBLAS_CFLAGS += -fno-asynchronous-unwind-tables
endif
endif

OPENBLAS_BUILD_OPTS += CFLAGS="$(CFLAGS) $(OPENBLAS_CFLAGS)"
OPENBLAS_BUILD_OPTS += FFLAGS="$(FFLAGS) $(OPENBLAS_FFLAGS)"
OPENBLAS_BUILD_OPTS += LDFLAGS="$(LDFLAGS) $(RPATH_ESCAPED_ORIGIN)"
Expand Down

0 comments on commit 6f6d5de

Please sign in to comment.