Fix big(typemin(T)) (#29340)

JuliaLang · Sep 26, 2018 · 7698523 · 7698523
1 parent 8d6c1ce
commit 7698523
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/base/gmp.jl b/base/gmp.jl
@@ -288,6 +288,7 @@ function BigInt(x::Integer)
     z = MPZ.realloc2(nd)
     s = sign(x)
     s == -1 && (x = -x)
+    x = unsigned(x)
     size = 0
     limbnbits = sizeof(Limb) << 3
     while nd > 0

diff --git a/test/bigint.jl b/test/bigint.jl
@@ -432,3 +432,11 @@ end
     y = rand(UInt128)
     @test BigInt(y) % UInt128 === y
 end
+
+@testset "conversion from typemin(T)" begin
+    @test big(Int8(-128)) == big"-128"
+    @test big(Int16(-32768)) == big"-32768"
+    @test big(Int32(-2147483648)) == big"-2147483648"
+    @test big(Int64(-9223372036854775808)) == big"-9223372036854775808"
+    @test big(Int128(-170141183460469231731687303715884105728)) == big"-170141183460469231731687303715884105728"
+end