-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find better names for traits TypeOrder, TypeArithmetic and TypeRangeStep #25440
Milestone
Comments
I like using the
|
Triage likes the |
StefanKarpinski
removed
the
status:triage
This should be discussed on a triage call
label
Jan 11, 2018
JeffBezanson
added a commit
that referenced
this issue
Jan 14, 2018
JeffBezanson
added a commit
that referenced
this issue
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed at #25402 (comment) and #20402 (comment), we should find better names for traits defined in traits.jl, since they are the only ones whose names start with
Type
. Here's a list with suggestions:TypeOrder
(possible choices:HasOrder
/Unordered
) ->OrderStyle
(Ordered
/Unordered
),HasOrder
(Ordered
/Unordered
) orIsOrdered
(Ordered
/Unordered
)TypeArithmetic
(ArithmeticRounds
/ArithmeticOverflows
/ArithmeticUnknown
) ->ArithmeticStyle
orArithmeticAccuracy
(BTW, it would make sense to addArithmeticExact
and divide overflow intoArithmeticWrapsAround
/ArithmeticSaturates
.)TypeRangeStep
(RangeStepRegular
/RangeStepIrregular
) ->RangeStep
orRangeStepStyle
The text was updated successfully, but these errors were encountered: