Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combinatorics coverage #11779

Merged
merged 1 commit into from
Jun 20, 2015
Merged

combinatorics coverage #11779

merged 1 commit into from
Jun 20, 2015

Conversation

Ismael-VC
Copy link
Contributor

:feelsgood: I just screwed it up again, when trying to squash accidentaly merged something else, continues #11778 I didn't know how to fix it so I did the PR again, sorry for the inconveniences.

@Ismael-VC Ismael-VC mentioned this pull request Jun 20, 2015
@Ismael-VC
Copy link
Contributor Author

Why does this lines are not exercised even when this tests are defined and CI is run on both 32 and 64 bits architectures?

@tkelman
Copy link
Contributor

tkelman commented Jun 20, 2015

The numbers that go to coveralls don't come from the same CI that tests PR's, they come from a separate 64 bit Ubuntu buildbot.

@Ismael-VC
Copy link
Contributor Author

All right then. Travis tests are passing, only AV is left. I'll keep looking for chances to make more tests.

@Ismael-VC
Copy link
Contributor Author

@tkelman couldn't we add something like this to the .travis.yml, script and after_success options, so we can have 32 bit coverage also?

@Ismael-VC
Copy link
Contributor Author

Is there any documentation on how this build bots work?

@tkelman
Copy link
Contributor

tkelman commented Jun 20, 2015

See the first post at #9493. The buildbot configuration lives at https://github.com/staticfloat/julia-buildbot and you can see the setup at http://buildbot.e.ip.saba.us:8010/builders. For measuring base coverage numbers, you have to do some custom configuration, run without inlining, and other modifications that are probably too slow to run on every travis build.

@Ismael-VC
Copy link
Contributor Author

Thank you very much for all your help!

@tkelman
Copy link
Contributor

tkelman commented Jun 20, 2015

No problem, test additions are great and always welcome. Thanks!

tkelman added a commit that referenced this pull request Jun 20, 2015
@tkelman tkelman merged commit 2f29e51 into JuliaLang:master Jun 20, 2015
@Ismael-VC Ismael-VC deleted the combinatorics-coverage branch June 20, 2015 16:25
@Ismael-VC Ismael-VC restored the combinatorics-coverage branch June 21, 2015 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants