showcompact(::RefValue) prints the contained object compactly #12929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,3 +70,10 @@ setindex!(b::RefValue, x) = (b.x = x; b) | |||
| setindex!(b::RefArray, x) = (b.x[b.i] = x; b) | |||
|
|
|||
| ### | |||
|
|
|||
| function showcompact(io::IO, b::RefValue) | |||
There was a problem hiding this comment.
Arrays already use showcompact for printing their elements, so I didn't think it was necessary. But I can change it if you think it's better that way.
There was a problem hiding this comment.
To clarify, sometimes showcompact(::Array) is bigger than show(::Array) because showcompact seems to do a showall even though it skips the formatting.
8 tasks
timholy
force-pushed
the
teh/showcompact_ref
branch
from
a6a305e
to
5df02ec
Compare
|
AFAICT, this seems unnecessary now with the IOContext overhaul. Thanks to @vtjnash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.