-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some indices generalizations for linalg/generic #18032
Conversation
Can you explain this a little more? Is |
Just for julia 0.5. See http://docs.julialang.org/en/latest/devdocs/offset-arrays/. |
I see. In the documentation, your suggestion is to use |
It's equivalent, see how I can add a comment if you like. Perhaps at the |
@nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
c4aa288
to
8ce2693
Compare
I know but I think it would be useful with a comment such that, in the future, we'll know why we are using a non-exported and non-documented function to compute the number of elements in an array. |
It's already there now, do you like it? Or should I move it somewhere else? |
I see. Thanks. I looked in the wrong file. It was something like that I had in mind. |
Feel free to suggest further changes, or if none perhaps we can merge. |
(cherry picked from commit f14c2ca)
This was also the occasion for #18031, but this version just keeps compatibility with what we currently have.