reshape(::Array, Val{N}) always returns an Array #18160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a convenience method,
reshape(A, Val{N})
, that reshapes toN
dimensions, "collapsing" trailing dimensions ifndims(A) > N
. However, one can also use this to "extend" dimensions, adding trailing 1s to the indices. When the array was anArray
, we were returning an Array forndims(A) >= N
but not forndims(A) <= N
.This was only a couple-line change, but I took the opportunity to move a few lines of code around to help clarify the organization.