Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: switch travis to sudo-required #22986

Merged
merged 1 commit into from
Sep 13, 2017
Merged

CI: switch travis to sudo-required #22986

merged 1 commit into from
Sep 13, 2017

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Jul 27, 2017

Recommend by Travis support to try for better performance of our builds.

@ararslan ararslan added the domain:ci Continuous integration label Jul 27, 2017
@tkelman
Copy link
Contributor

tkelman commented Jul 27, 2017

Looks like the sudo-enabled workers pull from a different cache than the sudo-disabled workers, so this is having to build deps from scratch. That's not the end of the world if it actually works as fast as Travis used to, it had been able to build deps in roughly 35 minutes then get to the end of the tests in just under 2 hours total. If this can't match that, we might be in a lot of trouble and need to really get on Travis' case or seek out alternatives and stop paying them for a service that isn't working for us any more.

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Jul 27, 2017

This appears to not have fixed the performance problem with travis.

@vtjnash vtjnash closed this Jul 31, 2017
@vtjnash vtjnash deleted the jn/travis-sudo branch July 31, 2017 19:20
@vtjnash vtjnash restored the jn/travis-sudo branch August 21, 2017 04:55
@vtjnash vtjnash reopened this Aug 21, 2017
@vtjnash vtjnash closed this Aug 21, 2017
@vtjnash vtjnash deleted the jn/travis-sudo branch August 21, 2017 17:41
@Keno Keno restored the jn/travis-sudo branch August 31, 2017 21:29
@Keno Keno reopened this Aug 31, 2017
@Keno
Copy link
Member

Keno commented Aug 31, 2017

Travis support suggested that they have changed some settings which may make this better.

@StefanKarpinski
Copy link
Sponsor Member

It does not seem to have fixed anything since the build took 2 hours and didn't complete. The network setup on the premium VMs has borked UDP too (incorrectly configured loopback interface).

@tkelman
Copy link
Contributor

tkelman commented Sep 1, 2017

It was quite a bit faster actually. Much of the time was spent building deps to populate the cache, which wouldn't have to be done on most builds. It runs on GCE and doesn't support ipv6 so we'd have to disable that socket test like we're doing on Circle. We can let Travis know this performed like their normal VM's used to, but for our purposes I think it would be better to get doc deployment working from Circle, then disable Linux builds on Travis.

@StefanKarpinski
Copy link
Sponsor Member

then disable Linux builds on Travis.

No, I've said many times that for the next several months we should double up on CI so that we always have some CI system that's working. We cannot afford to put all our eggs in one basket.

@ViralBShah
Copy link
Member

I agree that until 1.0 is out, let's just keep travis. If travis solves our issues, great. If not, we find an alternative.

@tkelman
Copy link
Contributor

tkelman commented Sep 1, 2017

What isn't working about Circle? Turning Linux Travis builds back on if we decide we want them again isn't exactly difficult, and in the meantime we'd have a faster turnaround on mac builds where Travis is currently our best option.

We can find out what it would require from Travis to keep the premium VM's indefinitely. There might be a way involving running some of the tests inside a docker container that could get the socket tests to pass. ref MariadeAnton#1

@ViralBShah
Copy link
Member

The point is that keep circle and travis both running. There is no need to disable anything on travis until 1.0. Worst case it keeps failing and we can ignore it.

@vtjnash vtjnash merged commit 0189574 into master Sep 13, 2017
@vtjnash vtjnash deleted the jn/travis-sudo branch September 13, 2017 15:40
ararslan pushed a commit that referenced this pull request Nov 10, 2017
ararslan pushed a commit that referenced this pull request Nov 14, 2017
ararslan pushed a commit that referenced this pull request Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants