Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the docs for "Standard Library" into "Base" and "Standard Library" #24461

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

KristofferC
Copy link
Sponsor Member

The docs right now is split into Manual and Standard Library (and Developer Docs). However, we are now more and more differentiating between what is part of "Base" and what is the "Standard Library". Therefore, I think it makes sense to split the header that is currently called "Standard Library" into two parts; one called "Base" (corresponding to functionality in the base foler) and one called "Standard Library" (which corresponds to the modules in stdlib).

WIP because the introduction to Base needs to be rewritten to not call it the Standard Library, and because there should probably be an introduction corresponding to the Standard Library header.

@StefanKarpinski
Copy link
Sponsor Member

💯

@ararslan ararslan added domain:docs This change adds or pertains to documentation stdlib Julia's standard library labels Nov 3, 2017
@Sacha0
Copy link
Member

Sacha0 commented Nov 4, 2017

This pull request brings the discussion in #23876 (comment) to mind. Migrating to stdpkg/"standard packages" would be a nice way to avoid ambiguity / confusion and maintain clear separation. Best!

@KristofferC
Copy link
Sponsor Member Author

Personally, I find the Base / Standard Library distinction to work quite well. Standard packages sounds a bit like an oxymoron to me.

@KristofferC KristofferC force-pushed the kc/restructure_docs branch 2 times, most recently from 35dac2e to 70a7d3b Compare January 7, 2018 16:57
@KristofferC
Copy link
Sponsor Member Author

KristofferC commented Jan 7, 2018

Alright, updated this. For those places in the Base documentation that were referring to Base as "the standard library", I changed this to "Julia Base". Any other suggestions?

There are a few places in the Manual section (Date and Datetime, Profiling) that should probably be moved completely to their stdlib documentation, but this can be done later.

I also took the opportunity to do a few things a bit more programmatically because I notice people miss some of the manual steps when moving out stuff to a new stdlib (add to .gitignore etc).

This is no longer WIP so please review.

@KristofferC KristofferC changed the title WIP RFC: split the docs for "Standard Library" into "Base" and "Standard Library" Split the docs for "Standard Library" into "Base" and "Standard Library" Jan 7, 2018
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@fredrikekre
Copy link
Member

Timeout on one Appveyor worker.

@KristofferC KristofferC merged commit 8e7ae9f into master Jan 9, 2018
@fredrikekre fredrikekre deleted the kc/restructure_docs branch January 9, 2018 14:24
@KristofferC KristofferC mentioned this pull request Jan 9, 2018
5 tasks

makedocs(
build = joinpath(pwd(), "_build/html/en"),
modules = [Base, Core, BuildSysImg, DelimitedFiles, Test, Mmap, SharedArrays, Profile,
Base64, FileWatching, Dates, IterativeEigensolvers, Unicode, Distributed, Printf],
modules = [Base, Core, BuildSysImg, [Module(stdlib.stdlib) for stdlib in STDLIB_DOCS]...],
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? I thought Module(x) made a new empty module.

Great change though 👍

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought Module(x) made a new empty module.

Well, clearly you haven't been programming Julia long enough...

It works in the sense that the docs render correctly as far as I can see.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird; something is up. stdlib.stdlib is a Symbol right?

julia> using Unicode

julia> Module(:Unicode) === Unicode
false

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it is wrong but the reason it still work, I think, is that none of the stdlib modules have any submodules, which is what Documenter uses this information. Will correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants