fix #22926, raw string escaping rules that allow writing all strings #24621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
kind:breaking
JeffBezanson
force-pushed
the
jb/rawstrings
branch
from
bddb358
to
2028ae8
Compare
NEWS.md
Outdated
| @@ -130,6 +130,10 @@ Language changes | |||
| * Like `_`, variable names consisting only of underscores can be assigned, | |||
| but accessing their values is deprecated ([#24221]). | |||
|
|
|||
| * Raw string literal escaping rules have been changed to make it possible to write all strings. | |||
| The rule is that backslashes escape both quotes and other backslashes, but only when appearing | |||
| directly before a quote character ([#22926]). | |||
There was a problem hiding this comment.
"but only when a sequence of backslashes precedes a quote character. Thus, 2n backslashes followed by a quote encodes n backslashes and the end of the literal while 2n+1 backslashes followed by a quote encodes n backslashes followed by a quote character."
base/strings/io.jl
Outdated
| The exception is that quotation marks still must be escaped. | ||
| The exception is that quotation marks still must be escaped. Backslashes | ||
| escape both question marks and other backslashes, but only when immediately | ||
| preceding a quote character. |
StefanKarpinski
approved these changes
Nov 15, 2017
vtjnash
approved these changes
Nov 15, 2017
|
Looks like there's a couple other tests to fix though too: Lines 742 to 745 in 2028ae8 |
JeffBezanson
force-pushed
the
jb/rawstrings
branch
from
2028ae8
to
5b0ae07
Compare
jmert
reviewed
Nov 16, 2017
base/strings/io.jl
Outdated
| @@ -371,15 +371,25 @@ macro b_str(s); :(Vector{UInt8}($(unescape_string(s)))); end | |||
| @raw_str -> String | |||
|
|
|||
| Create a raw string without interpolation and unescaping. | |||
| The exception is that quotation marks still must be escaped. | |||
| The exception is that quotation marks still must be escaped. Backslashes | |||
| escape both question marks and other backslashes, but only when a sequence | |||
There was a problem hiding this comment.
Good catch.
JeffBezanson
force-pushed
the
jb/rawstrings
branch
from
5b0ae07
to
f356869
Compare
Keno
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented @vtjnash 's proposal since that seemed to be the most popular.