Keywords unlocked 2 #25683
Keywords unlocked 2 #25683
Conversation
base/interactiveutil.jl
Outdated
| @@ -580,22 +580,22 @@ end | |||
|
|
|||
| # `methodswith` -- shows a list of methods using the type given | |||
| """ | |||
| methodswith(typ[, module or function][, showparents::Bool=false]) | |||
| methodswith(typ[, module or function]; parents::Bool=false]) | |||
There was a problem hiding this comment.
I think this should be called supertypes, following e.g. the supertype function.
| @@ -667,7 +667,7 @@ function findminmax!(f, Rval, Rind, A::AbstractArray{T,N}) where {T,N} | |||
| end | |||
|
|
|||
| """ | |||
| findmin!(rval, rind, A, [init=true]) -> (minval, index) | |||
| findmin!(rval, rind, A) -> (minval, index) | |||
There was a problem hiding this comment.
The init argument exists. I guess you intended to use ; to show it's a keyword argument? Same below.
There was a problem hiding this comment.
No I did this on purpose. #25188 (comment) where Stefan speculated init was a private keyword.
There was a problem hiding this comment.
Sorry, I had missed that. I'd remove the argument completely then, given that it doesn't seem to be used internally.
FWIW, sortperm! has an initialized=false argument which is somewhat similar (but reversed).
| @@ -672,7 +672,7 @@ function signature_type(@nospecialize(f), @nospecialize(args)) | |||
| end | |||
|
|
|||
| """ | |||
| code_lowered(f, types, expand_generated = true) | |||
| code_lowered(f, types; expand_generated = true) | |||
There was a problem hiding this comment.
Maybe this one could just be generated? That would parallel if @generated.
There was a problem hiding this comment.
I commented about this here: #25188 (comment). I'm not too passionate though so if people feel like generated makes sense I can change it.
|
I'll fix this up. |
Continuation of #25647, with keyword arguments which needed renaming as suggested here #25188. I chose
ncoresinstead ofcoresfollowing the discussion in #25659.