fix typo in Base.digits

[gsoleilhac]

Also adds deprecations for digits forgotten by #25647

[StefanKarpinski]

Looks good. Would you mind adding a test for this method?

[ararslan]

What's odd is that this is valid syntax, and indeed these methods are already covered by tests.

julia> f(x = x::Int = 1) = 1
f (generic function with 2 methods)

julia> f(1)
1

julia> f()
1

[mbauman]

Yeah, it looks like f(; x = y = 1) creates a y binding that is only available within other keywords — it cannot be used within the function body but it can be used in defining other keywords. It's a little strange, but it's consistent with how keywords generally work.

[ararslan]

Thanks for the contribution, @gsoleilhac!

[StefanKarpinski]

Oh, that is very weird. I wonder if it was intentional. @JeffBezanson?

[gsoleilhac]

I also noticed this, is it expected ?

julia> y
ERROR: UndefVarError: y not defined

julia> f(;x = y = 1) = x, y
f (generic function with 1 method)

julia> f(x = y = 1)
(1, 1)

julia> x
ERROR: UndefVarError: x not defined

julia> y
1

And methods(f) (or tab-completion) is definitevely wrong/misleading :

julia> methods(f)
# 1 method for generic function "f":
f(; x, y) in Main at REPL[1]:1

julia> f(x=1, y=2)
ERROR: MethodError: no method matching f(; x=1, y=2)
Closest candidates are:
  f(; x, y) at REPL[1]:1
Stacktrace:
 [1] (::#kw##f)(::Array{Any,1}, ::#f) at .\<missing>:0

[StefanKarpinski]

That's definitely a bug.