Move TerminalMenus.jl into a submodule of REPL #25956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
license: MIT
authors: Nick Paul
years: 2017
user: nick-paul
Julia Version 0.5.0 [3c9d753]
will make it easier to add and implement different menu types
In some OSX builds, STDOUT.buffer is undefined. Since it is a rare case, skip the test.
Add test functionality, fix #5
While a good default sometimes I want to display a menu on a terminal other than the main one (e.g. if I let somebody connect to my app via ssh or for a multi-terminal application). Add an optional first argument to allow specifying the terminal.
Allow specifying the terminal in `request`
Display exceptions
In general ^C throws InterruptException. The only reason this doesn't happen in TerminalMenus is because we enable raw mode which makes ^C just another key sequence. I think it is more coherent to make this throw an InterruptException as it would in non-raw parts of code. If the calling code wants to handle this, it can catch the exception.
Have ^C throw InterruptException
`config(ctrl_c_interrupt=true)` will throw an InterruptException() [default] `config(ctrl_c_interrupt=false)` will use old behavior and return an -1 or empty set
fix deprecation warnings
accept \eOx as well as \e[x for escapes (#12)
KristofferC
added
stdlib:REPL
KristofferC
force-pushed
the
kc/term_menus_stdlib
branch
from
4d3a1ee
to
13b9902
Compare
This was referenced Feb 9, 2018
|
CircleCI and FreeBSD already passed. Rerunning Travis and AppVeyor with whitespace fix. |
|
Win32 is the current standard failure, Win64 is a timeout – it almost passed but didn't quite make it. |
vchuravy
pushed a commit
to JuliaPackaging/LazyArtifacts.jl
that referenced
this pull request
Oct 2, 2023
…_stdlib Move TerminalMenus.jl into a submodule of REPL
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
Move TerminalMenus.jl into a submodule of REPL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pkg3 uses this awesome package and it has the potential to enable us implementing more interactive features, ref: nick-paul/TerminalMenus.jl#14
cc @nick-paul, @StefanKarpinski