Pkg don't use startup.jl when building and testing #29364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unless the user has explicitly asked for it with --startup-file=yes (cherry picked from commit 40d7f27f2ff08ec466df536f267129a9f5e950b4)
KristofferC
added
domain:packages
fredrikekre
reviewed
Sep 25, 2018
| @@ -1246,7 +1246,6 @@ Create a project called `pkgname` in the current folder. | |||
| precompile | |||
|
|
|||
| Precompile all the dependencies of the project by running `import` on all of them in a new process. | |||
| The `startup.jl` file is disabled during precompilation unless julia is started with `--startup-file=yes`. | |||
There was a problem hiding this comment.
Precompile function got changed, this is no longer applicable.
(cherry picked from commit 57f7380a2641944be12695e92a3ad9f4cc20e6f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a missing (important) backport, this was supposed to be in 1.0.