Adds iceil, ifloor and itrunc to BigFloat #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These random test errors are getting a bit annoying. Does anyone knows why do they happen? I sometimes get them on my machine too. |
|
Yeah, caused by #3015 |
|
They should always return |
|
I improved the state of julia> iround(Int8, 1355.12)
75
julia> iround(Int8, BigFloat(1355.12))
75I'm throwing an error in conversions from |
|
Please rebase then I will merge it. |
They convert to a Int64 if it fits, otherwise to BigInt.
It also includes extensive changes to the conversion of both BigInt and BigFloat in order to make them more general and to start raising errors when trying to convert values bigger than Clong/Culong.
|
Rebased. |
StefanKarpinski
added a commit
that referenced
this pull request
May 8, 2013
Adds iceil, ifloor and itrunc to BigFloat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They convert to a
Clongif it fits, otherwise toBigInt. It is inspired by #3040, but doesn't solve it directly.