Fix LU doctest broken by #32989. #33051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
referenced
this pull request
Aug 23, 2019
…2989) For types that weren't subtypes of AbstractFloat, we used to try to LU factorize without pivoting and only use pivoting when it failed. This caused large numerical errors when computing the LU for element types which promoted to float like numbers such as most integers. The behavior was never documented and is error prone. Hence, this PR removes the behavior.
fredrikekre
added
backport 1.3
domain:docs
KristofferC
pushed a commit
that referenced
this pull request
Aug 25, 2019
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.