Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libssh2 to v1.9.0, use MbedTLS on all platforms #33089

Merged
merged 2 commits into from
Sep 2, 2019

Conversation

staticfloat
Copy link
Sponsor Member

@staticfloat staticfloat commented Aug 27, 2019

@GunnarFarneback Here's the PR to bump libssh2.

This PR not only reduces the number of patches we need to apply, but it also switches to use MbedTLS as the backing crypto library on all platforms. This is to solve #28933 and also to work around bugs in WinCNG #32907 (comment).

@GunnarFarneback
Copy link
Contributor

Is something more needed before this can be merged?

@staticfloat
Copy link
Sponsor Member Author

I spoke with @vtjnash, he doesn't have a problem with this, so we're going to merge it and keep an eye out for strange problems.

@staticfloat staticfloat merged commit d3250fe into master Sep 2, 2019
@staticfloat staticfloat deleted the sf/libssh2_bump branch September 2, 2019 19:07
KristofferC pushed a commit that referenced this pull request Sep 3, 2019
* Bump libssh2 to `v1.9.0`, use MbedTLS on all platforms

* Remove patches from source builds

(cherry picked from commit d3250fe)
@KristofferC KristofferC mentioned this pull request Sep 3, 2019
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants