Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS #42538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't properly move the OpenBLAS -> Objconv dependency chain over to manifest files. This was not visible until now because we rarely build OpenBLAS from source without also building Objconv from source. Fixes #42519
staticfloat
force-pushed
the
sf/objconv_dep_fix
branch
from
f87c14e
to
830a3a1
Compare
ViralBShah
added
the
domain:building
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
* Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS We didn't properly move the OpenBLAS -> Objconv dependency chain over to manifest files. This was not visible until now because we rarely build OpenBLAS from source without also building Objconv from source. Fixes JuliaLang#42519 * Also update path to `objconv` binary
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
* Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS We didn't properly move the OpenBLAS -> Objconv dependency chain over to manifest files. This was not visible until now because we rarely build OpenBLAS from source without also building Objconv from source. Fixes JuliaLang#42519 * Also update path to `objconv` binary
|
I think this introduced the following bug: #44517 |
KristofferC
pushed a commit
that referenced
this pull request
May 23, 2022
* Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS We didn't properly move the OpenBLAS -> Objconv dependency chain over to manifest files. This was not visible until now because we rarely build OpenBLAS from source without also building Objconv from source. Fixes #42519 * Also update path to `objconv` binary (cherry picked from commit 6af7584)
KristofferC
pushed a commit
that referenced
this pull request
May 23, 2022
* Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS We didn't properly move the OpenBLAS -> Objconv dependency chain over to manifest files. This was not visible until now because we rarely build OpenBLAS from source without also building Objconv from source. Fixes #42519 * Also update path to `objconv` binary (cherry picked from commit 6af7584)
KristofferC
pushed a commit
that referenced
this pull request
Jul 4, 2022
* Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS We didn't properly move the OpenBLAS -> Objconv dependency chain over to manifest files. This was not visible until now because we rarely build OpenBLAS from source without also building Objconv from source. Fixes #42519 * Also update path to `objconv` binary (cherry picked from commit 6af7584)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
* Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS We didn't properly move the OpenBLAS -> Objconv dependency chain over to manifest files. This was not visible until now because we rarely build OpenBLAS from source without also building Objconv from source. Fixes #42519 * Also update path to `objconv` binary (cherry picked from commit 6af7584)
staticfloat
added a commit
that referenced
this pull request
Dec 23, 2022
* Fix USE_BINARYBUILDER_OPENBLAS=0 on macOS We didn't properly move the OpenBLAS -> Objconv dependency chain over to manifest files. This was not visible until now because we rarely build OpenBLAS from source without also building Objconv from source. Fixes #42519 * Also update path to `objconv` binary (cherry picked from commit 6af7584)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't properly move the OpenBLAS -> Objconv dependency chain
over to manifest files. This was not visible until now because we
rarely build OpenBLAS from source without also building Objconv from
source.
Fixes #42519