Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pickup ASAN and LLVM assertion build fixes from #43418 #43685

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Pickup ASAN and LLVM assertion build fixes from #43418 #43685

merged 3 commits into from
Jan 20, 2022

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Jan 6, 2022

  • fix compiler warning in cli
  • fix LLVM_ASSERTIONS build
  • sanitizers: fix support loading of libjulia-codegen
  • sanitizers: disable calls to pthread_atfork

Cherry-picked from #43418

@DilumAluthge
Copy link
Member

If you like, you can also push a revert of #43663 to this branch.

@vchuravy
Copy link
Member Author

vchuravy commented Jan 6, 2022

If you like, you can also push a revert of #43663 to this branch.

The real question is whether or not this unbreaks ASAN.

@DilumAluthge
Copy link
Member

We'll find out in a few minutes 😂

@vchuravy vchuravy marked this pull request as ready for review January 6, 2022 21:13
@vchuravy
Copy link
Member Author

vchuravy commented Jan 6, 2022

Looks very promising!

@vchuravy vchuravy requested a review from tkf January 6, 2022 21:36
@DilumAluthge
Copy link
Member

DilumAluthge commented Jan 6, 2022 •
edited
Loading

asan is green: https://buildkite.com/julialang/julia-master/builds/7258#9d65c5ea-a1cf-435e-bd4d-23116c3d3909

@DilumAluthge
Copy link
Member

llvmpasses is still red: https://buildkite.com/julialang/julia-master/builds/7258#9c7688cd-61a6-40fc-a949-71f6a3971664

tkf
tkf reviewed Jan 6, 2022
View reviewed changes
Copy link
Member

@tkf tkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C++ mangling is terrifying but anything that makes ASAN work LGTM :)

cli/loader_lib.c Outdated Show resolved Hide resolved
@vchuravy vchuravy added this to the 1.8 milestone Jan 8, 2022
vtjnash
vtjnash reviewed Jan 10, 2022
View reviewed changes
cli/loader_exe.c Outdated Show resolved Hide resolved
@vchuravy
Copy link
Member Author

But something is very wrong, I triggered another buiild before the revert commit https://buildkite.com/julialang/julia-master/builds/7542 IIRC asan was working okay then instead of having NaN everywhere...

@vtjnash @vchuravy
fix compiler warning in cli
92153f7
@vtjnash @vchuravy
fix LLVM_ASSERTIONS build
2268ee4
@vtjnash @vchuravy
sanitizers: disable calls to pthread_atfork
dd2e112 
OpenBLAS tries to do bad things in this callback (supposedly to support
use-after-fork), so we disable it entirely for TSAN/ASAN, where it
causes the sanitizers to deadlock.
@vtjnash vtjnash merged commit 2e854a4 into master Jan 20, 2022
@vtjnash vtjnash deleted the vc/llvm_asan branch January 20, 2022 17:47
@tkf tkf mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkf tkf tkf left review comments

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@vchuravy @DilumAluthge @tkf @vtjnash