Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Fix compillation of LLVM with system zlib #45119

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

giordano
Copy link
Contributor

Should fix #44584. CC: @fxcoudert

@giordano giordano added domain:building Build system, or building Julia or its dependencies system:mac Affects only macOS labels Apr 28, 2022
Copy link
Sponsor Member

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Apr 29, 2022
@giordano giordano merged commit 5e74df5 into JuliaLang:master Apr 29, 2022
@giordano giordano deleted the mg/llvm-system-zlib branch April 29, 2022 09:06
@giordano giordano added backport 1.8 Change should be backported to release-1.8 and removed status:merge me PR is reviewed. Merge when all tests are passing labels Apr 29, 2022
KristofferC pushed a commit that referenced this pull request May 16, 2022
@KristofferC KristofferC mentioned this pull request May 16, 2022
67 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to build julia-1.8.0-beta1 on macOS
4 participants