Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero-length array concatenation validation #45383

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

BioTurboNick
Copy link
Contributor

@BioTurboNick BioTurboNick commented May 20, 2022

Fixes #41605

A lot easier to address than I thought.

Candidate for 1.7.4 and 1.8.0 backport, though less critical.

@BioTurboNick BioTurboNick changed the title Fix zero-length array logic Fix zero-length array concatenation logic May 20, 2022
@BioTurboNick BioTurboNick changed the title Fix zero-length array concatenation logic Fix zero-length array concatenation validation May 20, 2022
@johnnychen94 johnnychen94 added domain:arrays [a, r, r, a, y, s] kind:bugfix This change fixes an existing bug labels May 20, 2022
@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Jun 1, 2022
@KristofferC KristofferC merged commit 0a55a8e into JuliaLang:master Jun 1, 2022
KristofferC pushed a commit that referenced this pull request Jun 7, 2022
@KristofferC KristofferC mentioned this pull request Jun 7, 2022
36 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:arrays [a, r, r, a, y, s] kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hvncat discards zero-length arrays rather than uses their shapes for correctness
3 participants