Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix convert call in Artifacts.jl #46040

Merged
merged 1 commit into from
Jul 14, 2022
Merged

fix convert call in Artifacts.jl #46040

merged 1 commit into from
Jul 14, 2022

Conversation

KristofferC
Copy link
Sponsor Member

Happened to see this in the VSCode linter.

@vchuravy vchuravy added backport 1.8 Change should be backported to release-1.8 needs tests Unit tests are required for this change backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 14, 2022
@KristofferC
Copy link
Sponsor Member Author

Regarding needs test, this might be dead code for all I know so it's mostly to silence the linter warning.

@staticfloat staticfloat merged commit e96b19d into master Jul 14, 2022
@staticfloat staticfloat deleted the kc/artifact_convert branch July 14, 2022 18:22
KristofferC added a commit that referenced this pull request Jul 17, 2022
KristofferC added a commit that referenced this pull request Jul 20, 2022
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Aug 7, 2022
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
KristofferC added a commit that referenced this pull request Dec 21, 2022
KristofferC added a commit that referenced this pull request Dec 21, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
KristofferC added a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6 Change should be backported to release-1.6 needs tests Unit tests are required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants