Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rem2pi for non-finite arguments #46163

Merged
merged 6 commits into from
Jul 25, 2022
Merged

fix rem2pi for non-finite arguments #46163

merged 6 commits into from
Jul 25, 2022

Conversation

oscardssmith
Copy link
Member

@oscardssmith oscardssmith commented Jul 25, 2022 •
edited
Loading

followup to #36420 that fixes Inf and -Inf as well (and I believe at slightly lower cost)

@oscardssmith
fix rem2pi for non-finite arguments
ddb1a00 
followup to https://github.com/JuliaLang/julia/pull/36420/files that fixes `Inf` and `-Inf` as well (and I believe at slightly lower cost)
@oscardssmith oscardssmith added the kind:bugfix This change fixes an existing bug label Jul 25, 2022
@oscardssmith
Copy link
Member Author

oscardssmith commented Jul 25, 2022 •
edited
Loading

We also should really make better implimentations of rem2pi for Float32 and Float16. Our current methods just use the Float32 impl, which is slower than necessary.

giordano
giordano reviewed Jul 25, 2022
View reviewed changes
base/math.jl Outdated Show resolved Hide resolved
@oscardssmith @giordano
Update base/math.jl
5c58abc 
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
@oscardssmith oscardssmith mentioned this pull request Jul 25, 2022
Merged
@oscardssmith oscardssmith added backport 1.6 Change should be backported to release-1.6 backport 1.7 backport 1.8 Change should be backported to release-1.8 labels Jul 25, 2022
@oscardssmith
Copy link
Member Author

ready to merge?

@giordano
Copy link
Contributor

Use isfinite everywhere else?

@oscardssmith
Copy link
Member Author

good point.

@fredrikekre fredrikekre merged commit 73c1eeb into master Jul 25, 2022
@fredrikekre fredrikekre deleted the oscardssmith-fix-rem2pi-nonfinite branch July 25, 2022 19:21
@giordano giordano mentioned this pull request Jul 25, 2022
Closed
@KristofferC KristofferC mentioned this pull request Aug 7, 2022
Merged
32 tasks
KristofferC pushed a commit that referenced this pull request Aug 7, 2022
@oscardssmith @KristofferC
fix rem2pi for non-finite arguments (#46163)
87d89f7 
(cherry picked from commit 73c1eeb)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Aug 7, 2022
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
@oscardssmith
fix rem2pi for non-finite arguments (JuliaLang#46163)
0786018
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@oscardssmith @pcjentsch
fix rem2pi for non-finite arguments (JuliaLang#46163)
f48231e
@KristofferC KristofferC mentioned this pull request Dec 21, 2022
Open
78 tasks
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@oscardssmith
fix rem2pi for non-finite arguments (#46163)
2526843 
(cherry picked from commit 73c1eeb)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@oscardssmith
fix rem2pi for non-finite arguments (#46163)
d5a2d31 
(cherry picked from commit 73c1eeb)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@oscardssmith
fix rem2pi for non-finite arguments (#46163)
b0fc5ec 
(cherry picked from commit 73c1eeb)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@oscardssmith
fix rem2pi for non-finite arguments (#46163)
fbf0050 
(cherry picked from commit 73c1eeb)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@oscardssmith @staticfloat
fix rem2pi for non-finite arguments (#46163)
4deffd1 
(cherry picked from commit 73c1eeb)
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
@oscardssmith @KristofferC
fix rem2pi for non-finite arguments (#46163)
783d152 
(cherry picked from commit 73c1eeb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oscardssmith @giordano @KristofferC @fredrikekre