Teach bb-install.mk to pick up special jlls for msan #46418
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified working by setting `SANITIZE_MEMORY=1` and then checking:
```
$ nm -D usr/lib/libstdc++.so | grep msan
U __msan_init
U __msan_memcpy
U __msan_memmove
U __msan_memset
U __msan_param_tls
U __msan_retval_tls
U __msan_va_arg_overflow_size_tls
U __msan_va_arg_tls
U __msan_warning_with_origin_noreturn
```
60 tasks
vtjnash
approved these changes
Sep 2, 2022
|
This was approved but never merged, and assigned to @gbaraldi who some time later opened a new PR #47420 with identical title to this one... So maybe this PR here should be closed in favor of the other? Or what is the status / relation? Or maybe this PR here is just a small step towards the more extensive work in #47420, and could / should be merged already now?! |
|
Yeah that second one was the one that got closer, but still had some issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified working by setting
SANITIZE_MEMORY=1and then checking: