LibGit2: correct regex for credential helpers #46597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barucden
force-pushed
the
credential_helpers
branch
from
e5b2ebf
to
43c6f50
Compare
The previous regex for credential helpers included even the following
credential:
```
[credential "helperselector"]
selected = manager-core
```
which gets introduced by Git for Windows and fails our assumption about
what a credential helper is.
The commit also removes a test that mirrors what `credential_helpers`
does (otherwise, we would have to maintain the same regex at two places,
the definition of `credential_helpers` and the test case).
Fixes JuliaLang#45693
barucden
force-pushed
the
credential_helpers
branch
from
43c6f50
to
0280c0a
Compare
|
The branch has been rebased. As far as I can tell, the test errors do not seem related so far. Can somebody review the changes, please? Maybe @fredrikekre? |
fredrikekre
added
backport 1.6
28 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 16, 2022
The previous regex for credential helpers included even the following
credential:
```
[credential "helperselector"]
selected = manager-core
```
which gets introduced by Git for Windows and fails our assumption about
what a credential helper is.
The commit also removes a test that mirrors what `credential_helpers`
does (otherwise, we would have to maintain the same regex at two places,
the definition of `credential_helpers` and the test case).
Fixes #45693
(cherry picked from commit ea74208)
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous regex for credential helpers included even the following
credential:
which gets introduced by Git for Windows and fails our assumption about
what a credential helper is.
The commit also removes a test that mirrors what
credential_helpersdoes (otherwise, we would have to maintain the same regex at two places,
the definition of
credential_helpersand the test case).Fixes #45693