Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve type stability of process_overrides(artifact_dict::Dict, pkk_uuid::Base.UUID) #46661

Merged
merged 5 commits into from
Sep 14, 2022

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Sep 7, 2022

This fixes some invalidations when loading Static.jl.

I used the following code to find this problem:

julia> import Pkg; Pkg.activate(temp=true); Pkg.add("Static")

julia> using SnoopCompileCore; invalidations = @snoopr(using Static); using SnoopCompile

julia> trees = invalidation_trees(invalidations);

julia> import Artifacts; ftrees = filtermod(Artifacts, trees)
1-element Vector{SnoopCompile.MethodInvalidations}:
 inserting !(::False) in Static at ~/.julia/packages/Static/sVI3g/src/Static.jl:427 invalidated:
   mt_backedges: 1: signature Tuple{typeof(!), Any} triggered MethodInstance for Artifacts.process_overrides(::Dict{String, Any}, ::Base.UUID) (3 children)

This PR gets us one step closer to finally fixing SciML/Static.jl#77.

I suggest the labels latency and backport-1.8.

…_uuid::Base.UUID)`

This fixes some invalidations when loading Static.jl
@ranocha
Copy link
Member Author

ranocha commented Sep 7, 2022

Can we get the backport-1.8 label here, please? It would be great to fix SciML/Static.jl#77 in Julia v1.8.2.

@dkarrasch dkarrasch added compiler:latency Compiler latency backport 1.8 Change should be backported to release-1.8 labels Sep 8, 2022
@ranocha ranocha mentioned this pull request Sep 9, 2022
28 tasks
@KristofferC KristofferC merged commit b4af0e5 into JuliaLang:master Sep 14, 2022
@ranocha ranocha deleted the hr/process_overrides branch September 14, 2022 13:21
KristofferC pushed a commit that referenced this pull request Sep 16, 2022
…_uuid::Base.UUID)` (#46661)

* improve type stability of `process_overrides(artifact_dict::Dict, pkg_uuid::Base.UUID)`

This fixes some invalidations when loading Static.jl

(cherry picked from commit b4af0e5)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:latency Compiler latency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants