inference: make limit::Int as a caching key of CachedMethodTable
#46799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes `Core.Compiler.findall(::Type, ::CachedMethodTable; limit::Int)` is called with different `limit` setting (in particularity `return_type_tfunc` calls it with `limit=-1`). The query should return different results given different `limit` settings, so its cache should also have different keys per different `limit` settings. fix #46722
aviatesk
added
compiler:inference
|
@nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
vtjnash
approved these changes
Sep 16, 2022
aviatesk
added a commit
that referenced
this pull request
Sep 17, 2022
…46799) Sometimes `Core.Compiler.findall(::Type, ::CachedMethodTable; limit::Int)` is called with different `limit` setting (in particularity `return_type_tfunc` calls it with `limit=-1`). The query should return different results given different `limit` settings, so its cache should also have different keys per different `limit` settings. fix #46722
|
Isn't there any test that could be added? |
aviatesk
added a commit
that referenced
this pull request
Sep 18, 2022
aviatesk
added a commit
that referenced
this pull request
Sep 18, 2022
aviatesk
added a commit
that referenced
this pull request
Sep 18, 2022
aviatesk
added a commit
that referenced
this pull request
Sep 18, 2022
KristofferC
pushed a commit
that referenced
this pull request
Sep 19, 2022
…46799) Sometimes `Core.Compiler.findall(::Type, ::CachedMethodTable; limit::Int)` is called with different `limit` setting (in particularity `return_type_tfunc` calls it with `limit=-1`). The query should return different results given different `limit` settings, so its cache should also have different keys per different `limit` settings. fix #46722
KristofferC
pushed a commit
that referenced
this pull request
Sep 19, 2022
…46799) Sometimes `Core.Compiler.findall(::Type, ::CachedMethodTable; limit::Int)` is called with different `limit` setting (in particularity `return_type_tfunc` calls it with `limit=-1`). The query should return different results given different `limit` settings, so its cache should also have different keys per different `limit` settings. fix #46722
aviatesk
added a commit
that referenced
this pull request
Dec 9, 2022
…46799) Sometimes `Core.Compiler.findall(::Type, ::CachedMethodTable; limit::Int)` is called with different `limit` setting (in particularity `return_type_tfunc` calls it with `limit=-1`). The query should return different results given different `limit` settings, so its cache should also have different keys per different `limit` settings. fix #46722
aviatesk
added a commit
that referenced
this pull request
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
Core.Compiler.findall(::Type, ::CachedMethodTable; limit::Int)is called with differentlimitsetting (in particularityreturn_type_tfunccalls it withlimit=-1). The query should return different results given differentlimitsettings, so its cache should also have different keys per differentlimitsettings.fix #46722