Add native julia fmod #47501
Merged
Add native julia fmod #47501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Nov 8, 2022
oscardssmith
reviewed
Nov 8, 2022
ararslan
reviewed
Nov 9, 2022
oscardssmith
reviewed
Nov 9, 2022
oscardssmith
reviewed
Nov 9, 2022
oscardssmith
reviewed
Nov 9, 2022
ararslan
reviewed
Nov 10, 2022
ararslan
reviewed
Nov 10, 2022
ararslan
reviewed
Nov 10, 2022
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
|
I think this looks ready! I'll merge in a few days if no one objects. |
ararslan
reviewed
Nov 12, 2022
Co-authored-by: Alex Arslan <ararslan@comcast.net>
ararslan
reviewed
Nov 12, 2022
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
ararslan
reviewed
Nov 15, 2022
|
Do we want this in 1.9? |
|
Imo yes, it fixes a perf regression |
51 tasks
|
should we merge this now? |
|
I believe so, if we find a way to fix the effects of the bitwise operations without breaking other things we can change here. |
|
Merge? |
KristofferC
pushed a commit
that referenced
this pull request
Dec 8, 2022
* Add native julia rem Co-authored-by: Alex Arslan <ararslan@comcast.net> (cherry picked from commit cf5ae03)
26 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #46467
Based on LLVMs libc implementation. About 5x faster than openlibm and 10% slower than glibc.
Tested on all values of Float16 and a large amount of Float32 and 64.
The amount of tests might be a bit much, since it's the exact same codepath independent of type. But maybe I should add some explicit Float16 tests. That function there tests all possible combinations but it's a bit too long.