-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert Improve effect analysis of bitshifts #47567 #47830
Conversation
Open an issue to keep track of that? |
Okay but why? What is the bug in this PR and should a corresponding test be added so that it doesn't regress again? |
@KristofferC it wasn't a bug, just that the way it widened applicable types caused ambiguity errors for packages that tried to extend it. |
Could you add a simplified test case, i.e. the operation that caused the issue now doesn't widen them? |
@oscardssmith bump? |
sorry, I did a bad job explaining what is wrong here. the PR didn't change any values, but meant that new types wouldn't work. I'm not sure there is a great way to test for this. |
This broke the BitIntegers package. It would be good to fix the original issue from the compiler side.