Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent return value for annotations, take 2 #53333

Merged
merged 2 commits into from
Feb 20, 2024
Merged

More consistent return value for annotations, take 2 #53333

merged 2 commits into from
Feb 20, 2024

Commits on Feb 19, 2024

  1. Reapply "More consistent return value for annotations" (JuliaLang#53309) 

    This reverts commit 81c3474.
    @tecosaur @KristofferC
    tecosaur authored and KristofferC committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6bc4e8a View commit details
    Browse the repository at this point in the history

  2. Correct annotation calculation with annot substr 

    The commit e1a76bb was ultimately
reverted due to it seeming to introduce an abort signal in CI. It turns
out there's an underlying issue with a compiler flag being broken,
however I've also noticed that the annotation calculation for SubStrings
was incorrect, as it didn't take into account the substring offset or
width. We might as well fix this.
    @tecosaur @KristofferC
    tecosaur authored and KristofferC committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    efa721b View commit details
    Browse the repository at this point in the history