Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some UB from examples in performance tips #54221

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

LilithHafner
Copy link
Member

Remove some UB from examples in performance tips

Fixes #54218

I also changed the iteration specification to better align with elsewhere in the document.

A separate PR may want to delete or revise this section if automatic simd has improved. Nevertheless, I think this PR should be unobjectionable as is.

@LilithHafner LilithHafner added domain:docs This change adds or pertains to documentation kind:bugfix This change fixes an existing bug labels Apr 23, 2024
@LilithHafner LilithHafner added the status:merge me PR is reviewed. Merge when all tests are passing label Apr 23, 2024
@fatteneder fatteneder merged commit 9b44239 into master Apr 23, 2024
6 of 10 checks passed
@fatteneder fatteneder deleted the lh/remove-some-ub branch April 23, 2024 21:50
@fatteneder fatteneder removed the status:merge me PR is reviewed. Merge when all tests are passing label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance tips recommend invalid use of @inbounds
3 participants