Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unconditional warning before handling StackOverflow #54622

Merged
merged 2 commits into from
Jun 5, 2024
Merged

add unconditional warning before handling StackOverflow #54622

merged 2 commits into from
Jun 5, 2024

Commits on Jun 4, 2024

  1. only install error frame if fully allocated and valid 

    Avoids a race condition where a signal (e.g. StackOverflowError) happens
while trying to initialize the rest of the frame, resulting in trying to
longjmp to garbage.
    @vtjnash
    vtjnash committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f613ee3 View commit details
    Browse the repository at this point in the history

  2. add unconditional warning before handling StackOverflow 

    Since this is not modeled by the exception logic, and it can interrupt
arbitrary program state or corrupt locks (leading to hangs and other
issues), as well as just frequently segfaulting afterwards, give a
printed message as soon as we notice things are going badly before
attempting to recover.
    @vtjnash
    vtjnash committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    21b1e15 View commit details
    Browse the repository at this point in the history