Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL: disable flaky win32 stacktrace tests #55408

Conversation

IanButterworth
Copy link
Sponsor Member

@IanButterworth IanButterworth commented Aug 7, 2024

Disables these tests on win32 that have been flaky on that platform since February at least #53340

  | 2024-08-07 12:02:57 EDT | REPL                                            (11) \|         failed at 2024-08-07T16:03:13.216
  | 2024-08-07 12:03:13 EDT | Test Failed at C:\buildkite-agent\builds\win2k22-amdci6-0\julialang\julia-master\julia-dcab5c9d52\share\julia\stdlib\v1.12\REPL\test\repl.jl:247
  | 2024-08-07 12:03:13 EDT | Expression: startswith(s, "\e[0mERROR: unterminated single quote\nStacktrace:\n  [1] ") \|\| startswith(s, "\e[0m\e[1m\e[91mERROR: \e[39m\e[22m\e[91munterminated single quote\e[39m\nStacktrace:\n  [1] ")
  | 2024-08-07 12:03:13 EDT |  
  | 2024-08-07 12:03:13 EDT | Test Failed at C:\buildkite-agent\builds\win2k22-amdci6-0\julialang\julia-master\julia-dcab5c9d52\share\julia\stdlib\v1.12\REPL\test\repl.jl:1653
  | 2024-08-07 12:03:13 EDT | Expression: readline(stdout_read) == ""
  | 2024-08-07 12:03:13 EDT | Evaluated: "Stacktrace:" == ""
  | 2024-08-07 12:03:13 EDT |  
  | 2024-08-07 12:03:13 EDT | Test Failed at C:\buildkite-agent\builds\win2k22-amdci6-0\julialang\julia-master\julia-dcab5c9d52\share\julia\stdlib\v1.12\REPL\test\repl.jl:1658
  | 2024-08-07 12:03:13 EDT | Expression: readline(stdout_read) == "\e[0m"
  | 2024-08-07 12:03:13 EDT | Evaluated: "\e[0m1-element ExceptionStack:" == "\e[0m"

@IanButterworth IanButterworth added system:windows Affects only Windows test This change adds or pertains to unit tests labels Aug 7, 2024
@giordano
Copy link
Contributor

giordano commented Aug 7, 2024

Fixes #53340

Is it fixing the issue or merely hiding it? When #50071 skipped flaky tests it didn't close any issue and rather added references to the issue in the skipped tests, since they were still real.

@IanButterworth
Copy link
Sponsor Member Author

IanButterworth commented Aug 7, 2024

Maybe we need a disabled test label?

Also, should these be @test skip=..? So that they count on the report?

@giordano
Copy link
Contributor

giordano commented Aug 7, 2024

Also, should these be @test skip=..? So that they count on the report?

👍

@ararslan ararslan added stdlib:REPL Julia's REPL (Read Eval Print Loop) system:32-bit Affects only 32-bit systems labels Aug 7, 2024
@JeffBezanson JeffBezanson merged commit f276757 into JuliaLang:master Aug 8, 2024
9 checks passed
@IanButterworth IanButterworth deleted the ib/win32_disable_flaky_stacktrace_tests branch August 8, 2024 23:10
lazarusA pushed a commit to lazarusA/julia that referenced this pull request Aug 17, 2024
Disables these tests on win32 that have been flaky on that platform
since February at least JuliaLang#53340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib:REPL Julia's REPL (Read Eval Print Loop) system:windows Affects only Windows system:32-bit Affects only 32-bit systems test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants