Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @time_imports extension recognition #55718

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix @time_imports extension recognition #55718

merged 2 commits into from
Sep 10, 2024

Conversation

IanButterworth
Copy link
Sponsor Member

@IanButterworth IanButterworth commented Sep 9, 2024 •
edited
Loading

Fixes #55713

Note the last line.

julia> @time_imports using Plots
      0.7 ms  Printf
     16.4 ms  Dates
      0.8 ms  Statistics
               ┌ 2.9 ms SuiteSparse_jll.__init__()
      4.7 ms  SuiteSparse_jll
      0.7 ms  Serialization
               ┌ 4.9 ms SparseArrays.CHOLMOD.__init__() 89.00% compilation time
    184.1 ms  SparseArrays 37.22% compilation time (73% recompilation)
      0.4 ms  Statistics → SparseArraysExt

@IanButterworth IanButterworth added the backport 1.11 Change should be backported to release-1.11 label Sep 9, 2024
@IanButterworth IanButterworth marked this pull request as ready for review September 9, 2024 03:44
@IanButterworth IanButterworth added the status:merge me PR is reviewed. Merge when all tests are passing label Sep 10, 2024
@IanButterworth IanButterworth merged commit d280792 into JuliaLang:master Sep 10, 2024
8 checks passed
@IanButterworth IanButterworth deleted the ib/time_imports_ext_fix branch September 10, 2024 11:34
@giordano giordano removed the status:merge me PR is reviewed. Merge when all tests are passing label Sep 11, 2024
KristofferC pushed a commit that referenced this pull request Sep 11, 2024
@IanButterworth
Fix @time_imports extension recognition (#55718)
6270b90 
(cherry picked from commit d280792)
@KristofferC KristofferC mentioned this pull request Sep 11, 2024
Merged
33 tasks
kshyatt pushed a commit that referenced this pull request Sep 12, 2024
@IanButterworth @kshyatt
Fix @time_imports extension recognition (#55718)
66fd0bf
KristofferC added a commit that referenced this pull request Sep 17, 2024
@KristofferC
Backports for 1.11.0-rc4/1.11.0 (#55586)
6cb5b1f 
Backported PRs:
- [x] #55480 <!-- Fix push! for OffsetVectors, add tests for push! and
append! on AbstractVector -->
- [x] #55443 <!-- Add test for upper/lower/titlecase and fix call -->
- [x] #55524 <!-- Set `.jl` sources as read-only during installation -->
- [x] #55500 <!-- make jl_thread_suspend_and_get_state safe -->
- [x] #55506 <!-- Fix indexing in _mapreducedim for OffsetArrays -->
- [x] #55564 <!-- Empty out loaded_precompiles dict instead of asserting
it's empty. -->
- [x] #55567 <!-- Initialize threadpools correctly during sysimg build
-->
- [x] #55596 <!-- Fast bounds-check for CartesianIndex ranges -->
- [x] #55605 <!-- Reroute Symmetric/Hermitian + Diagonal through
triangular -->
- [x] #55640 <!-- win: move stack_overflow_warning to the backtrace
fiber -->
- [x] #55715 <!-- Add precompile signatures to Markdown to reduce
latency. -->
- [x] #55593 <!-- Fix invalidations for FileIO -->
- [x] #55555 <!-- Revert "Don't expose guard pages to malloc_stack API
consumers" -->
- [x] #55720 <!-- Fix `pkgdir` for extensions -->
- [x] #55729 <!-- Avoid confounding compilation side effects of
`@time_imports` -->
- [x] #55718 <!-- Fix `@time_imports` extension recognition -->
- [x] #55522 <!-- Fix tr for Symmetric/Hermitian block matrices -->

Contains multiple commits, manual intervention needed:
- [ ] #55509 <!-- Fix cong implementation to be properly random and not
just cycling. -->

Non-merged PRs with backport label:
- [ ] #55641 <!-- fall back to slower stat filesize if optimized
filesize fails -->
- [ ] #55534 <!-- Set stdlib sources as read-only during installation
-->
- [ ] #55499 <!-- propagate the terminal's `displaysize` to the
`IOContext` used by the REPL -->
- [ ] #55458 <!-- Allow for generically extracting unannotated string
-->
- [ ] #55457 <!-- Make AnnotateChar equality consider annotations -->
- [ ] #55453 <!-- Privatise the annotations API, for StyledStrings -->
- [ ] #55355 <!-- relocation: account for trailing path separator in
depot paths -->
- [ ] #55220 <!-- `isfile_casesensitive` fixes on Windows -->
- [ ] #55169 <!-- `propertynames` for SVD respects private argument -->
- [ ] #54457 <!-- Make `String(::Memory)` copy -->
- [ ] #53957 <!-- tweak how filtering is done for what packages should
be precompiled -->
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
- [ ] #50813 <!-- More doctests for Sockets and capitalization fix -->
- [ ] #50157 <!-- improve docs for `@inbounds` and
`Base.@propagate_inbounds` -->
- [ ] #41244 <!-- Fix shell `cd` error when working dir has been deleted
-->
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC Awaiting requested review from KristofferC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@time_imports not showing extension parents
3 participants
@IanButterworth @giordano @KristofferC