Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FileWatching designs and add workaround for a stat bug on Apple #55877

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix FileWatching designs and add workaround for a stat bug on Apple #55877

wants to merge 3 commits into from
+494 −355

Commits on Sep 30, 2024

  1. [FileWatching] fix PollingFileWatcher design and add workaround for a… 

    … stat bug

What started as an innocent fix for a stat bug on Apple (#48667) turned
into a full blown investigation into the design problems with the libuv
backend for PollingFileWatcher, and writing my own implementation of it
instead which could avoid those singled-threaded concurrency bugs.
    @vtjnash
    vtjnash committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e500754 View commit details
    Browse the repository at this point in the history

  2. [FileWatching] fix FileMonitor similarly and improve pidfile reliability 

    Previously pidfile used the same poll_interval as sleep to detect if
this code made any concurrency mistakes, but we do not really need to do
that once FileMonitor is fixed to be reliable in the presence of
parallel concurrency (instead of using watch_file).
    @vtjnash
    vtjnash committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b6e0136 View commit details
    Browse the repository at this point in the history

  3. [FileWatching] reorganize file and add docs

    @vtjnash
    vtjnash committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f8d17e7 View commit details
    Browse the repository at this point in the history