Use tempname() instead of custom file path in test/pkg.jl #8942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes calling Base.runtests("pkg") when Julia is installed in a
prefix where typical user does not have write access.
nolta
added a commit
that referenced
this pull request
Nov 10, 2014
Use tempname() instead of custom file path in test/pkg.jl
|
Cc: @JuliaBackports |
|
backported in 84f6a45 |
|
I think I'm going to have to revert this on both branches, will test locally first. Since |
This was referenced Nov 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes calling Base.runtests("pkg") when Julia is installed in a
prefix where typical user does not have write access.
Please just confirm there wasn't a good reason not to use
tempname. BTW, I can also update the docs for that function to say that it "Generate a unique temporary file or directory name", not just a "temporary filename". Or even better, a "temporary file or directory path". Right?