Specialize view for a BandSlice (#429)

* Specialize view for a BandSlice * Add test
JuliaLinearAlgebra · Mar 10, 2024 · a44ab1d · a44ab1d · jishnub · Mar 10, 2024
1 parent ddf6ab5
commit a44ab1d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "BandedMatrices"
 uuid = "aae01518-5342-5314-be14-df237901396f"
-version = "1.5.0"
+version = "1.6.0"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

diff --git a/src/generic/Band.jl b/src/generic/Band.jl
@@ -218,7 +218,8 @@ for f in (:indices, :unsafe_indices, :axes1, :first, :last, :size, :length,
     @eval $f(S::BandSlice) = $f(S.indices)
 end
 
-@propagate_inbounds getindex(S::BandSlice, i::Union{Int, AbstractRange}) = getindex(S.indices, i)
+@propagate_inbounds getindex(S::BandSlice, i::Union{Int, AbstractRange{<:Integer}}) = getindex(S.indices, i)
+@propagate_inbounds view(S::BandSlice, i::AbstractRange{<:Integer}) = view(S.indices, i)
 show(io::IO, r::BandSlice) = print(io, BandSlice, "(", r.band, ", ", r.indices, ")")
 
 to_index(::Band) = throw(ArgumentError("Block must be converted by to_indices(...)"))

diff --git a/test/test_indexing.jl b/test/test_indexing.jl
@@ -774,6 +774,7 @@ import BandedMatrices: rowstart, rowstop, colstart, colstop,
                         @test bs.indices == diagind(A, k)
                         @test bs.band == Band(k)
                         @test collect(bs) == collect(diagind(A, k))
+                        @test view(bs, 1:length(bs)) === view(diagind(A, k), 1:length(bs))
                         @test Vector{eltype(A)}(V) == collect(V) == A[diagind(A,k)] == A[band(k)]
                         @test Vector{ComplexF64}(V) == Vector{ComplexF64}(A[diagind(A,k)]) ==
                                 convert(AbstractVector{ComplexF64}, V) == convert(AbstractArray{ComplexF64}, V)