add tests

JuliaLinearAlgebra · Jul 19, 2023 · c834fb7 · c834fb7
1 parent 7905029
commit c834fb7
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "BandedMatrices"
 uuid = "aae01518-5342-5314-be14-df237901396f"
-version = "0.17.30"
+version = "0.17.31"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

diff --git a/src/banded/BandedMatrix.jl b/src/banded/BandedMatrix.jl
@@ -148,11 +148,15 @@ convert(::Type{DefaultBandedMatrix}, M::AbstractMatrix{T}) where T = convert(Def
 
 copy(B::BandedMatrix) = _BandedMatrix(copy(B.data), B.raxis, B.l, B.u)
 
-LinearAlgebra.copymutable_oftype(B::BandedMatrix, ::Type{S}) where S =
-    _BandedMatrix(LinearAlgebra.copymutable_oftype(B.data, S), B.raxis, B.l, B.u)
+if isdefined(LinearAlgebra, :copymutable_oftype)
+    LinearAlgebra.copymutable_oftype(B::BandedMatrix, ::Type{S}) where S =
+        _BandedMatrix(LinearAlgebra.copymutable_oftype(B.data, S), B.raxis, B.l, B.u)
 
-LinearAlgebra.copymutable_oftype(B::Adjoint{<:Any,<:BandedMatrix}, ::Type{S}) where S =
-    LinearAlgebra.copymutable_oftype(parent(B), S)'
+    LinearAlgebra.copymutable_oftype(B::Adjoint{<:Any,<:BandedMatrix}, ::Type{S}) where S =
+        LinearAlgebra.copymutable_oftype(parent(B), S)'
+    LinearAlgebra.copymutable_oftype(B::Transpose{<:Any,<:BandedMatrix}, ::Type{S}) where S =
+        transpose(LinearAlgebra.copymutable_oftype(parent(B), S))
+end
 
 promote_rule(::Type{BandedMatrix{T1, C1}}, ::Type{BandedMatrix{T2, C2}}) where {T1,C1, T2,C2} =
     BandedMatrix{promote_type(T1,T2), promote_type(C1, C2)}

diff --git a/test/test_banded.jl b/test/test_banded.jl
@@ -505,4 +505,16 @@ Base.similar(::MyMatrix, ::Type{T}, m::Int, n::Int) where T = MyMatrix{T}(undef,
             @test @view(p[2:3]) == 2:3
         end
     end
+
+    if isdefined(LinearAlgebra, :copymutable_oftype)
+        @testset "copymutable_oftype" begin
+            B = _BandedMatrix((2:3)', 4, -2, 2)
+            @test LinearAlgebra.copymutable_oftype(B, Float64) == B
+            @test LinearAlgebra.copymutable_oftype(B, Float64) isa BandedMatrix{Float64}
+            @test LinearAlgebra.copymutable_oftype(B', Float64) == B'
+            @test LinearAlgebra.copymutable_oftype(B', Float64) isa Adjoint{Float64,<:BandedMatrix{Float64}}
+            @test LinearAlgebra.copymutable_oftype(transpose(B), Float64) == transpose(B)
+            @test LinearAlgebra.copymutable_oftype(transpose(B), Float64) isa Transpose{Float64,<:BandedMatrix{Float64}}
+        end
+    end
 end