Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DSP conv type piracy #146

Merged
merged 2 commits into from
Jul 29, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 29, 2023

Most of these methods have now been moved to InfiniteArrays as a package extension for DSP. The methods for AbstractFill are unnecessary, and tests for these are added in JuliaArrays/FillArrays.jl#289

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12% ⚠️

Comparison is base (0fc3526) 80.11% compared to head (9520d86) 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   80.11%   80.00%   -0.12%     
==========================================
  Files          11       10       -1     
  Lines        1418     1380      -38     
==========================================
- Hits         1136     1104      -32     
+ Misses        282      276       -6     
Files Changed Coverage Δ
src/InfiniteLinearAlgebra.jl 92.30% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit c053ac7 into JuliaLinearAlgebra:master Jul 29, 2023
8 checks passed
@jishnub jishnub deleted the removeDSPtypepiracy branch July 29, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant