[windows] Fix self-path lookup on Windows #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
force-pushed
the
sf/win32_self_handle
branch
from
84f0fee
to
3743ed2
Compare
Store handle to self in `DllMain` so that we don't try to figure out a handle to ourselves (incorrectly) anymore on Windows. Add test for LBT path printing when `LBT_VERBOSE=1`
staticfloat
force-pushed
the
sf/win32_self_handle
branch
from
3743ed2
to
7bb81a4
Compare
|
It looks like Yggdrasil is failing on this PR on windows: JuliaPackaging/Yggdrasil#6462 |
|
Did you fix it? |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store handle to self in
DllMainso that we don't try to figure out a handle to ourselves (incorrectly) anymore on Windows.