Test on ppc64le and armv7l as well
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
force-pushed
the
sf/more_testing
branch
10 times, most recently
from
ab65de1
to
c55968b
Compare
Because armv7 opcodes are only 32 bits, `mov` can only move immediates that are 8 bits or less. There's some wiggle room with shifting and whatnot, but in full generality you need to actually perform a load from a memory address. The assembler will insert the immediate into a literal pool, but that pool has to be <4KB away from the current `pc` at the time of load, so we add `.ltorg` to flush the literal pool at the end of every function.
staticfloat
force-pushed
the
sf/more_testing
branch
from
c55968b
to
875e610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.